add Gojek #290
Merged
add Gojek #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rizdaprasetya
commented
Oct 10, 2019
rizdaprasetya
commented
- Added the Gojek Logo
- Updated README.md
- Added SVG to Reference index.md
- Updated SVG index.md
- Fixed microsoft ref image path typo from this PR Add Microsoft (#262) #289
edent
requested changes
Oct 10, 2019
images/svg/gojek.svg
Outdated
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" aria-label="Gojek" role="img" viewBox="0 0 512 512"><rect width="512" height="512" fill="#fff" rx="15%"/><path fill="#00AA13" d="M192 261a64 64 0 11128 1 64 64 0 01-128-1"/><path fill="#00AA13" d="M256 91a171 171 0 00-66 328 32 32 0 0044-24 32 32 0 00-19-35 106 106 0 0141-205 107 107 0 0141 205 32 32 0 0013 61 33 33 0 0012-3 170 170 0 00-66-327"/></svg> | |||
There was a problem hiding this comment.
Would a <circle> element be smaller than a path?
Also, please could you add some newlines?
<svg
xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%"
fill="#fff"/>...</svg>
There was a problem hiding this comment.
You got it 👌
- Circle saved 12 bytes. But as side effect the autogenerated Android XML drawable grew a bit (because
circleis auto converted topath). - new lines added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.