Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed luckyframework alignment and smoothed edges (also half the size) #324

Merged
merged 6 commits into from
Oct 18, 2019
Merged

Fixed luckyframework alignment and smoothed edges (also half the size) #324

merged 6 commits into from
Oct 18, 2019

Conversation

vangyyy
Copy link
Contributor

@vangyyy vangyyy commented Oct 16, 2019

Much smaller icon
Smoother and aligned edges

@vangyyy
Copy link
Contributor Author

vangyyy commented Oct 17, 2019

Android drawable already fixed in #300.

@edent
Copy link
Owner

edent commented Oct 18, 2019

Think you've included the wrong file in this commit. The SVG looks like an Inkscape export.

vangyyy and others added 3 commits October 18, 2019 12:44
Needs a space so screen readers can pronounce it.
@edent
Copy link
Owner

edent commented Oct 18, 2019

Thanks. Just to note, I've added a space into the ARIA label. That's so screen readers can pronounce it properly. I think there are a few already in the repo I need to correct.

@edent edent merged commit ed2112a into edent:master Oct 18, 2019
@vangyyy
Copy link
Contributor Author

vangyyy commented Oct 18, 2019

Yes, I looked at one and it didn't have space, so I didn't use one also. When I find some missing spaces in the future, I'll fix them.

@vangyyy vangyyy deleted the fix-lucky-framework branch October 18, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants