Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CentOS #343

Merged
merged 1 commit into from
Oct 24, 2019
Merged

add CentOS #343

merged 1 commit into from
Oct 24, 2019

Conversation

romain-dartigues
Copy link
Collaborator

After RedHat, CentOS!

@edent
Copy link
Owner

edent commented Oct 24, 2019

Very clever work! Doesn't seem to render in Firefox for Android. Let me check what's causing the issue.

@edent
Copy link
Owner

edent commented Oct 24, 2019

Aha! Two small things, and one irrelevant thing.

  1. use href doesn't work on some renderers unless you explicitly use xmlns:xlink="http://www.w3.org/1999/xlink"
  2. The style stuff should work - but doesn't seem to affect the width on all renderers.
  3. No need for <g id="h"> - just added weight.

Here's a new version at 762 bytes. Only slightly larger than yours, but should work everywhere.

<svg xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink"
aria-label="CentOS" role="img"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%"
fill="#fff"/><g id="g"><rect x="118" y="118" fill="#9ccd2a" width="124" height="124"/><rect x="270" y="118" fill="#932279" width="124" height="124"/><rect x="270" y="270" fill="#efa724" width="124" height="124"/><rect x="118" y="270" fill="#262577" width="124" height="124"/></g><use xlink:href="#g" transform="rotate(225 256 256)"/><path d="M118 270h124v124H118zm152 0h124v124H270zm0-152h124v124H270zm-152 0h124v124H118zm245 226l-87-88 87-88 88 88zM256 236l-88-87 88-88 88 88zM149 344l-88-88 88-88 87 88zm107 107l-88-88 88-87 88 87z" fill="none" stroke="#fff" stroke-width="9"/></svg>

@romain-dartigues
Copy link
Collaborator Author

  1. use href doesn't work on some renderers unless you explicitly use xmlns:xlink="http://www.w3.org/1999/xlink"

Well shoot, and I just though I was smart finding xlink was deprecated... :,^(

  1. The style stuff should work - but doesn't seem to affect the width on all renderers.

Dang, here goes my optimization once again.

  1. No need for <g id="h"> - just added weight.

Oh, you are right, a remnant of my trials and errors.

Here's a new version at 762 bytes. Only slightly larger than yours, but should work everywhere.

Thanks for your time :^)

Special thanks to Terence who've been all the way to make it work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants