Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiktok.svg #532

Merged
merged 3 commits into from
May 12, 2021
Merged

Update tiktok.svg #532

merged 3 commits into from
May 12, 2021

Conversation

kpym
Copy link
Contributor

@kpym kpym commented May 10, 2021

This file is bigger by 38 bytes (446 => 484) but it avoids the use of <!ENTITY ...> and <!DOCTYPE ...> and as consequence:

  • It respect the template starting with <svg xmlns="http://www.w3.org/2000/svg" ...>.
  • This svg code can be integrated directly in html.

This file is bigger by 38 bytes (446 => 484) but it avoids the use of `<!ENTITY ...>` and `<!DOCTYPE ...>` and as consequence:
- It respect the template starting with `<svg xmlns="http://www.w3.org/2000/svg" ...>`.
- This `svg` code can be integrated directly in `html`.
@kpym
Copy link
Contributor Author

kpym commented May 10, 2021

tiktok.svg is the only icon that has <!DOCTYPE> before the <svg> tag.

@edent
Copy link
Owner

edent commented May 10, 2021

Brilliant stuff. Please update the README and I'll merge.

@edent edent merged commit 93d1040 into edent:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants