Add Logitech logo (726 bytes) (#596)

[qianzhong516]

Hi, I have added a Logitech logo. Please let me know further issues, thanks!

[edent]

That's a great start! Please can you follow the guide in https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md
Then I'll merge.

[qianzhong516]

Hi @edent, I have tried both
printf %s "$(cat $filename)" > filename-without-nl.svg and,
sed -i -z s/\\n$// filename.svg listed in the contrubution.md.
However, I don't see any changes appeared in the file.

The Logitech logo still not showing on the README.md. I think it's because of the wrong format of my svg file. Can you please let me know where I have done wrong? Thanks!

[Mottie]

Try this (375 bytes)

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"
aria-label="Logitech" role="img"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%" fill="#fff"/>
<path fill="#00a7e0" d="M348.9 390.7H426V223.3H258.6v77.1h90.3v90.3zm-91.8-24.5a109.4 109.4 0 0 1 0-218.8V70C153 70 68.9 153.8 68.9 256.6s84.5 186.7 187.9 186.7l.3-77.1z"/></svg>

[qianzhong516]

Try this (375 bytes)

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"
aria-label="Logitech" role="img"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%" fill="#fff"/>
<path fill="#00a7e0" d="M348.9 390.7H426V223.3H258.6v77.1h90.3v90.3zm-91.8-24.5a109.4 109.4 0 0 1 0-218.8V70C153 70 68.9 153.8 68.9 256.6s84.5 186.7 187.9 186.7l.3-77.1z"/></svg>

Thanks, but it still shows not found on the README page, maybe there is some other issue...

[PaulCapron]

Thanks, but it still shows not found on the README page, maybe there is some other issue...

The SVGs in the README are referenced using the absolute URL of edent repository: https://edent.github.io/SuperTinyIcons/images/svg/…

So the Logitech logo can display only if your PR is merged (into edent repo.)

[qianzhong516]

Hi @PaulCapron, thank you for the explaination. I have reverted the logo to my original version but trimed down the file size a little bit. @Mottie's work is better but I don't want to take the credit for his work. Please merge the 657 Bytes version and Rob can optimise my solution afterwards if he would like to :)

[Mottie]

@qianzhong516 Please go ahead and use the svg I shared. I don't care about credit 😺

[edent]

Thanks all - looking good now.