Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added matrix logo #676

Merged
merged 2 commits into from
Oct 22, 2022
Merged

added matrix logo #676

merged 2 commits into from
Oct 22, 2022

Conversation

maxiwolleb
Copy link
Contributor

Created a clean PR now, i did my best to do everything according to the CONTRIBUTING.md.
If i need to change anything please let me know.

Issue: #553

@edent
Copy link
Owner

edent commented Oct 20, 2022

I'm sorry, I haven't explained this very well. That's my fault. Let me try to be clearer.

Firstly, your SVG is formatted like this

<svg aria-label="matrix" role="img" version="1.1" viewBox="0 0 512 512" xmlns="http://www.w3.org/2000/svg">
 <rect width="512" height="512" rx="15%" fill="#fff"/>
 <g transform="matrix(.8 0 0 .8 43 43)">
  <path d="m25 23v466h34v11h-46v-489h46v11zm143 148v24h0.7c6-9 14-16 23-21s19-7 31-7c11 0 21 2 30 6s16 12 21 23c5-8 12-14 21-20s19-9 31-9c9 0 18 1 26 3s15 6 20 11 10 11 13 19 5 18 5 29v117h-48v-99c0-6-0.2-11-0.7-17s-2-10-4-13c-2-4-5-7-9-9s-9-3-16-3-12 1-16 4-7 6-10 10c-2 4-4 9-5 14-0.8 5-1 11-1 16v97h-48v-98c0-5-0.09-10-0.4-15-0.2-5-1-10-3-14s-5-8-8-10-10-4-17-4c-2 0-5 0.5-9 2s-7 3-11 6-6 7-9 12-4 12-4 21v101h-48v-174zm320 319v-466h-34v-11h46v489h-46v-11z"/>
 </g>
</svg>

The template shows it should look like this:

<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><rect
width="512" height="512"
rx="15%"
fill="#fff"/>...</svg>

Do you see the difference? The reason why the line breaks are where they are - and the ordering is the way it is - allows us to easily see changes to the SVG.

Secondly, your SVG doesn't fit inside a circle. If you change the radius to rx="50%" you'll see that the [ and ] break outside of it.

Try looking at

Hope that helps! Sorry for the confusion.

@maxiwolleb
Copy link
Contributor Author

maxiwolleb commented Oct 20, 2022

@edent I fixed it. Can u please take a look again. it Shouldnt be overflowing anymore :)

image

@edent edent merged commit 662f369 into edent:master Oct 22, 2022
@Unpublished Unpublished mentioned this pull request Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants