Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google icon #76

Merged
merged 3 commits into from
Nov 28, 2017
Merged

Fix Google icon #76

merged 3 commits into from
Nov 28, 2017

Conversation

ErikHumphrey
Copy link
Contributor

@ErikHumphrey ErikHumphrey commented Nov 27, 2017 •
edited

Fixes #57

473 or 770 bytes. May have removed too many tags.

@ErikHumphrey ErikHumphrey mentioned this pull request Nov 27, 2017
Closed
arturoacevedob
arturoacevedob reviewed Nov 27, 2017
View reviewed changes
Copy link
Collaborator

@arturoacevedob arturoacevedob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labels > aria-label="Google" role="img" < are necessary for accessibility.

@edent
Copy link
Owner

edent commented Nov 28, 2017

Thanks both! BTW @ErikHumphrey - I spent a year abroad studying at Carleton. Go Senators!

@edent edent merged commit 0b3a4d1 into edent:master Nov 28, 2017
romain-dartigues pushed a commit to romain-dartigues/SuperTinyIcons that referenced this pull request Oct 4, 2019
@ErikHumphrey
Fix Google icon (edent#76)
73ad77d 
* Fix Google icon

Fixes edent#57

* Update google.svg

* Add tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturoacevedob arturoacevedob arturoacevedob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ErikHumphrey @edent @arturoacevedob