New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fantomas to 6.1.0-alpha-003 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a strict version here.
Directory.Packages.props
Outdated
@@ -5,7 +5,7 @@ | |||
</PropertyGroup> | |||
|
|||
<ItemGroup> | |||
<PackageVersion Include="Fantomas.Core" Version="[6.0.0]" /> | |||
<PackageVersion Include="Fantomas.Core" Version="6.1.0-alpha-003" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to keep the [
]
here.
There is no guarantee that any Fantomas.Core
version is compatible.
See docs
And please update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more hiccup I'm afraid.
There is no unit test in https://github.com/edgarfgp/Fabulous.AST/blob/main/src/Fabulous.AST.Tests/TypeDefinitions/Class.fs that covers multiple parameters in the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 👍
No description provided.