fix: address code smells and other issues (#215)

* fix: use randbytes to generate fake file contents

* fix: remove default LIMESURVEY_URL in integration tests

* chore: add .sonarcloud.properties

* fix: random.randbytes is available only in 3.9+

* fix: make LSRC url a test fixture

.sonarcloud.properties

@@ -0,0 +1 @@
+sonar.python.version=3.7, 3.8, 3.9, 3.10

tests/test_client.py

@@ -4,6 +4,8 @@
 
 import base64
 import io
+import random
+import sys
 from pathlib import Path
 from typing import Any, Generator
 
@@ -16,6 +18,16 @@
 NEW_SURVEY_NAME = "New Survey"
 
 
+def _get_random_bytes(n: int):
+    return random.getrandbits(n * 8).to_bytes(n, "little")
+
+
+if sys.version_info >= (3, 9):
+    randbytes = random.randbytes
+else:
+    randbytes = _get_random_bytes
+
+
 class MockSession(Session):
     """Mock RPC session with some hardcoded methods for testing."""
 
@@ -300,8 +312,7 @@ def test_get_available_languages(client: MockClient):
 
 def test_import_group(client: MockClient, tmp_path: Path):
     """Test import_group client method."""
-    # TODO: generate this truly randomly
-    random_bytes = b"1924m01'9280u '0', u'012"
+    random_bytes = randbytes(100)
 
     filepath = Path(tmp_path) / "group.lsq"
 
@@ -314,8 +325,7 @@ def test_import_group(client: MockClient, tmp_path: Path):
 
 def test_import_question(client: MockClient, tmp_path: Path):
     """Test import_question client method."""
-    # TODO: generate this truly randomly
-    random_bytes = b"1924m01'9280u '0', u'012"
+    random_bytes = randbytes(100)
 
     filepath = Path(tmp_path) / "question.lsq"
 
@@ -328,8 +338,7 @@ def test_import_question(client: MockClient, tmp_path: Path):
 
 def test_import_survey(client: MockClient, tmp_path: Path):
     """Test import_survey client method."""
-    # TODO: generate this truly randomly
-    random_bytes = b"1924m01'9280u '0', u'012"
+    random_bytes = randbytes(100)
 
     filepath = Path(tmp_path) / "survey.lss"
 

tests/test_integration.py

@@ -14,7 +14,6 @@
 from citric import enums
 from citric.exceptions import LimeSurveyStatusError
 
-LS_URL = os.getenv("LIMESURVEY_URL", "http://limesurvey/index.php/admin/remotecontrol")
 LS_USER = "iamadmin"
 LS_PW = "secret"
 
@@ -38,10 +37,16 @@ def enable_json_rpc():
         conn.commit()
 
 
+@pytest.fixture(scope="session")
+def url() -> str:
+    """Get LimeSurvey RC URL."""
+    return os.environ["LIMESURVEY_URL"]
+
+
 @pytest.fixture(scope="module")
-def client() -> Generator[citric.Client, None, None]:
+def client(url: str) -> Generator[citric.Client, None, None]:
     """RemoteControl2 API client."""
-    client = citric.Client(LS_URL, LS_USER, LS_PW)
+    client = citric.Client(url, LS_USER, LS_PW)
 
     yield client