Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add import_question RPC method to Client #148

Merged
merged 4 commits into from Feb 3, 2022
Merged

feat: add import_question RPC method to Client #148

merged 4 commits into from Feb 3, 2022

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Feb 3, 2022 •
edited

  • Add Client.import_question
  • Add Client.add_group

Closes #147

@edgarrmondragon edgarrmondragon self-assigned this Feb 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022 •
edited

Codecov Report

Merging #148 (b4283ed) into master (3986870) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          196       201    +5     
  Branches        23        23           
=========================================
+ Hits           196       201    +5
Impacted Files Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3986870...b4283ed. Read the comment docs.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 3, 2022 03:20
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon changed the title feat: add import_question RPC method to Client feat: add import_question RPC method to Client Feb 3, 2022
@edgarrmondragon edgarrmondragon merged commit 782a969 into master Feb 3, 2022
@edgarrmondragon edgarrmondragon deleted the feature-import-question branch February 3, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edgarrmondragon edgarrmondragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add import_question RPC method to Client
2 participants
@edgarrmondragon @codecov-commenter