Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement delete_group in client #194

Merged
merged 1 commit into from
Feb 6, 2022
Merged

feat: implement delete_group in client #194

merged 1 commit into from
Feb 6, 2022
+19 −2

Conversation

edgarrmondragon
Copy link
Owner

Closes #193

@edgarrmondragon edgarrmondragon self-assigned this Feb 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #194 (643f797) into master (23bb9b7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          216       218    +2     
  Branches        24        24           
=========================================
+ Hits           216       218    +2
Impacted Files Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bb9b7...643f797. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon merged commit ecc5117 into master Feb 6, 2022
@edgarrmondragon edgarrmondragon deleted the delete-group branch February 6, 2022 07:09
@edgarrmondragon edgarrmondragon added RPC Issues related to the RPC client implementation enhancement New feature or request labels Feb 15, 2022
@edgarrmondragon edgarrmondragon added this to In progress in High-Level Python API via automation Feb 15, 2022
@edgarrmondragon edgarrmondragon moved this from In progress to Done in High-Level Python API Feb 15, 2022
@edgarrmondragon edgarrmondragon added this to the Full API coverage milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edgarrmondragon edgarrmondragon

Labels
enhancement New feature or request RPC Issues related to the RPC client implementation
Projects
High-Level Python API
Status: Done
High-Level Python API
  
Done
Milestone
Full API coverage
Development

Successfully merging this pull request may close these issues.

Feature: implement delete_group in client
2 participants
@edgarrmondragon @codecov-commenter