Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_uploaded_file_objects to Client #435

Merged
merged 2 commits into from May 2, 2022

Conversation

edgarrmondragon
Copy link
Owner

Closes #434

@edgarrmondragon edgarrmondragon self-assigned this May 2, 2022
@edgarrmondragon edgarrmondragon changed the title feat: add to Client feat: add get_uploaded_file_objects to Client May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #435 (5648633) into master (c473182) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          272       310   +38     
  Branches        31        35    +4     
=========================================
+ Hits           272       310   +38     
Impacted Files Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c473182...5648633. Read the comment docs.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 2, 2022 04:18
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon merged commit d89f4f3 into master May 2, 2022
@edgarrmondragon edgarrmondragon deleted the 434-uploaded-dataclasses branch May 2, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add a new get_uploaded_file_objects that generates structued objects with the file metadata
1 participant