Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edgedb-js doesn't pick up environment variable EDGEDB_DATABASE #163

Closed
haikyuu opened this issue Sep 7, 2021 · 0 comments · Fixed by #173
Closed

edgedb-js doesn't pick up environment variable EDGEDB_DATABASE #163

haikyuu opened this issue Sep 7, 2021 · 0 comments · Fixed by #173

Comments

@haikyuu
Copy link

haikyuu commented Sep 7, 2021

It would be nice to be able to EDGEDB_DATABASE=test npm start and the client would use the database passed instead of the default one.

That would be aligned with the behaviour of edgedb cli and would cause no surprises since the user added the env. variable explicitly.

See discussion edgedb/edgedb#2902

That's just a nice to have, because it can actually work like this: createPool({database:process.env.EDGEDB_DATABASE}) and would default to the default db if the env. variable is undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant