Enforce newly created exclusive constraints across tables #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And on rebases also.
elprans
reviewed
Mar 15, 2022
edb/pgsql/delta.py
Outdated
| @@ -1768,6 +1812,20 @@ def apply( | |||
| constraint, schema, context, self.source_context) | |||
| self.pgops.add(op) | |||
|
|
|||
| # If the constraint is being added to existing data, | |||
| # we need to enforce it on the existing data. (This only | |||
| # matters for | |||
elprans
approved these changes
Mar 15, 2022
|
Cherry picked to 1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And on rebases also.
In order to make it work for constraints on abstract links, abstract link views need
to be fixed to include
source, which is a bit hacky.That is a change to the pgsql schema, but we can avoid any trouble from that by
forcing a view update whenever we are generating code that might reference
the
sourceof an abstract link view. I tested that bit manually.