Fix slicing of tuple arrays with null inputs #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue here was kind of silly: NULL was being produced, as is proper, but because the Index and Slice nodes in pgast weren't derived from BaseExpr (since they weren't *really* exprs), _infer_nullability didn't consider it when figuring out the nullability of the output slice, which then didn't get checked for NULL and was output to the client.
elprans
approved these changes
Sep 23, 2022
msullivan
added a commit
that referenced
this pull request
Sep 23, 2022
The issue here was kind of silly: NULL was being produced, as is proper, but because the Index and Slice nodes in pgast weren't derived from BaseExpr (since they weren't *really* exprs), _infer_nullability didn't consider it when figuring out the nullability of the output slice, which then didn't get checked for NULL and was output to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was kind of silly: NULL was being produced, as is
proper, but because the Index and Slice nodes in pgast weren't derived
from BaseExpr (since they weren't really exprs), _infer_nullability
didn't consider it when figuring out the nullability of the output
slice, which then didn't get checked for NULL and was output to the
client.