Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify if orphan #4858

Merged
merged 1 commit into from Jan 5, 2023
Merged

Clarify if orphan #4858

merged 1 commit into from Jan 5, 2023

Conversation

raddevon
Copy link
Contributor

to address #4717

Please check the accuracy of this when you get a chance, @msullivan. I'm particularly concerned if I properly understand the implications I've described in the second paragraph of my note.

If my description is accurate, I wonder if we can and should consider another way to handle beyond just documenting it as-is. I feel like the result I've described would be fairly surprising.

Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is all correct

@msullivan
Copy link
Member

We definitely could implement the other behavior.

I believe that Elvis was concerned about the performance implications, though it might not be that bad: we have to do the exact same checks when we actually do delete an object as we do to check if it is an orphan...

@raddevon
Copy link
Contributor Author

raddevon commented Jan 5, 2023

Thanks for checking this, @msullivan. Glad to have it documented.

Maybe it's worthwhile to discuss whether changing the behavior or maybe offering both (if local orphan/if global orphan or something like that) would be worth the trade-off.

@raddevon raddevon merged commit 4c5860d into master Jan 5, 2023
@raddevon raddevon deleted the docs-clarify-if-orphan branch January 5, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants