Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Insert (Alternative Method) #4922

Merged
merged 13 commits into from Jan 25, 2023
Merged

Fix Insert (Alternative Method) #4922

merged 13 commits into from Jan 25, 2023

Conversation

zchenb
Copy link
Contributor

@zchenb zchenb commented Jan 24, 2023 •
edited

Changed inserts to take a single object reference.

@zchenb
Copy link
Contributor Author

zchenb commented Jan 25, 2023

I prefer the method of #4920, but the modified grammar will cause test failures. This is a workaround.

@zchenb zchenb marked this pull request as ready for review January 25, 2023 00:08
msullivan
msullivan approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

What do you prefer about the other version? (Using AtomicExpr doesn't seem like the right thing)

@zchenb
Copy link
Contributor Author

zchenb commented Jan 25, 2023

This version may be better if AtomicExpr is not the right thing. Shall I go ahead and merge?

@msullivan
Copy link
Member

Go for it

@zchenb zchenb merged commit b48cf82 into master Jan 25, 2023
@zchenb zchenb deleted the zc/insert_fix_2 branch January 25, 2023 18:33
@zchenb zchenb mentioned this pull request Jan 25, 2023
Closed
msullivan pushed a commit that referenced this pull request Feb 9, 2023
@zchenb @msullivan
Fix Insert (Alternative Method) (#4922)
a07effd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

@vpetrovykh vpetrovykh Awaiting requested review from vpetrovykh

@elprans elprans Awaiting requested review from elprans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zchenb @msullivan