Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom function calls on the HTTP interface #4998

Merged
merged 1 commit into from Feb 10, 2023
Merged

Conversation

msullivan
Copy link
Member

The problem was that, if no global variables were passed,
we were passing in NULL for the global variable JSON object,
which causes strict functions to spuriously return NULL.

Fixes #4989

The problem was that, if no global variables were passed,
we were passing in NULL for the global variable JSON object,
which causes strict functions to spuriously return NULL.

Fixes #4989
Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msullivan msullivan merged commit 2e0e6af into master Feb 10, 2023
@msullivan msullivan deleted the http-functions branch February 10, 2023 00:25
msullivan added a commit that referenced this pull request Feb 10, 2023
The problem was that, if no global variables were passed,
we were passing in NULL for the global variable JSON object,
which causes strict functions to spuriously return NULL.

Fixes #4989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom function wasn't supported via HTTP
2 participants