Support casting between scalars with a common concrete base #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like this was not supported because of an oversight, and then I unthinkingly added a test that asserted the behavior after I permuted some related code in #3662.
msullivan
force-pushed
the
allow-scalar-cast
branch
from
7d1a6ce
to
94eccd7
Compare
elprans
reviewed
Feb 28, 2023
edb/edgeql/compiler/casts.py
Outdated
| and (nearest := s_utils.get_class_nearest_common_ancestors( | ||
| ctx.env.schema, [new_stype, orig_stype])) | ||
| and len(nearest) == 1 | ||
| and not nearest[0].get_abstract(ctx.env.schema) |
There was a problem hiding this comment.
This wouldn't work if the nearest common ancestor is an abstract subtype of a non-abstract parent, e.g
create abstract scalar type foo extending str;
create scalar type bar1 extending foo;
create scalar type bar2 extending foo;
So:
Suggested change
| and not nearest[0].get_abstract(ctx.env.schema) | |
| and nearest[0].maybe_get_topmost_concrete_base(ctx.env.schema) is not None |
There was a problem hiding this comment.
Actually, I think the whole check should just compare the results of maybe_get_topmost_concrete_base, because
create abstract scalar type foo extending str;
create abstract scalar type bar extending str;
create scalar type bar1 extending foo, bar;
create scalar type bar2 extending foo, bar;
There was a problem hiding this comment.
Oh, yeah, indeed; I had misremembered and thought scalars could only have one base, but it's actually they can have one concrete ancestor
There was a problem hiding this comment.
And this is probably faster too
elprans
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this was not supported because of an oversight, and then I
unthinkingly added a test that asserted the behavior after I permuted
some related code in #3662.