Fix pg_namespace emulation
#5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current emulation of `pg_namespace` is somewhat broken because it returns `NULL` for `tableoid` for synthesized schemes, which throws off catalog map logic in `pg_dump` of PostgreSQL 15. Emit OID of `pg_namespace` correctly instead. While at it, set `xmin`, `xmax`, `cmin`, `cmax` to non-`NULL` values as well. `ctid` is harder to emulate correctly so leave it as `NULL`.
aljazerzen
approved these changes
Jun 5, 2023
|
Hmm, I think this also needs to be backported as a metaschema patch. |
msullivan
pushed a commit
that referenced
this pull request
Jun 9, 2023
Current emulation of `pg_namespace` is somewhat broken because it returns `NULL` for `tableoid` for synthesized schemes, which throws off catalog map logic in `pg_dump` of PostgreSQL 15. Emit OID of `pg_namespace` correctly instead. While at it, set `xmin`, `xmax`, `cmin`, `cmax` to non-`NULL` values as well. `ctid` is harder to emulate correctly so leave it as `NULL`. Backport note: this needs a patch to work on older installs, but I'm skipping the patch for now and letting it get picked up by a pending one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current emulation of
pg_namespaceis somewhat broken because itreturns
NULLfortableoidfor synthesized schemes, which throws offcatalog map logic in
pg_dumpof PostgreSQL 15. Emit OID ofpg_namespacecorrectly instead. While at it, setxmin,xmax,cmin,cmaxto non-NULLvalues as well.ctidis harder toemulate correctly so leave it as
NULL.