Fix some obscure optional bugs in the presence of tuple projections #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attaching a path in the scope tree, the detection of whether the *target* node was optional was insufficient. It only checked the node itself, but needs to check all the way to the factoring point. I think that logic had forgotten about BRANCHes that weren't FENCEs. This came up in a branch where I was experimenting with always BRANCHing function arguments as a way to validate *sometimes* branching function arguments to produce code that hits ORDER BY indexes in complex pgvector cases.
elprans
approved these changes
Jun 7, 2023
msullivan
added a commit
that referenced
this pull request
Jun 7, 2023
…5610) When attaching a path in the scope tree, the detection of whether the *target* node was optional was insufficient. It only checked the node itself, but needs to check all the way to the factoring point. I think that logic had forgotten about BRANCHes that weren't FENCEs. This came up in a branch where I was experimenting with always BRANCHing function arguments as a way to validate *sometimes* branching function arguments to produce code that hits ORDER BY indexes in complex pgvector cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attaching a path in the scope tree, the detection of whether the
target node was optional was insufficient. It only checked the node
itself, but needs to check all the way to the factoring point.
I think that logic had forgotten about BRANCHes that weren't FENCEs.
This came up in a branch where I was experimenting with always
BRANCHing function arguments as a way to validate sometimes
branching function arguments to produce code that hits ORDER BY
indexes in complex pgvector cases.