Fix casts to scalars #5624
Merged
Fix casts to scalars #5624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
reviewed
Jun 8, 2023
edb/edgeql/compiler/casts.py
Outdated
| # here, where we have access to the enum type. Just turn | ||
| # it into json->str and str->enum. | ||
| # Casts from json to may have special handling. | ||
| # So we turn it into json->str and str->x. |
There was a problem hiding this comment.
We need to go through the scalar's base type, not always through str, I think
msullivan
pushed a commit
that referenced
this pull request
Jun 9, 2023
We've had a codepath to fix this bug for enum already, but now I extended it to anything that: * is a scalar, * it not the top-most concrete base of itself, Closes #5616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5616
We've had a codepath to fix this bug for enum already, but now I extended it to anything that:
ir_set.path_id).