Add support for statement variants of prepared statement comands #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljazerzen
approved these changes
Jun 26, 2023
Comment on lines
+115
to
+119
| @dataclasses.dataclass(frozen=True) | ||
| class SQLSource: | ||
| chunks: list[str] | ||
| param_index: dict[int, list[int]] | ||
| translation_data: Optional[SQLSourceGeneratorTranslationData] = None |
There was a problem hiding this comment.
I've opened a PR that does a refactor of codegen, which will conflict with these changes.
The changes are in the same light (adding dataclasses as such), and should not be hard to update the these changes.
| @@ -156,25 +165,30 @@ def ctes_to_source(cls, ctes: List[pgast.CommonTableExpr]) -> str: | |||
| return ''.join(generator.result) | |||
|
|
|||
| @classmethod | |||
| def to_source_with_translation( | |||
| def to_source_ex( | |||
There was a problem hiding this comment.
Yeah. "extended" or "expert" (I'm not sure what the origin for Ex was in WinAPI). Suggestions for a better name welcome.
This adds support for `PREPARE`, `EXECUTE` and `DEALLOCATE` at SQL level. There is a fair bit of cleanup as well, removing unnecessary duplication in the form of `sql_simple_query` as we translate client simple query requests to extended query requests anyway.
msullivan
pushed a commit
that referenced
this pull request
Jul 6, 2023
This adds support for `PREPARE`, `EXECUTE` and `DEALLOCATE` at SQL level. There is a fair bit of cleanup as well, removing unnecessary duplication in the form of `sql_simple_query` as we translate client simple query requests to extended query requests anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
PREPARE,EXECUTEandDEALLOCATEat SQLlevel. There is a fair bit of cleanup as well, removing unnecessary
duplication in the form of
sql_simple_queryas we translate clientsimple query requests to extended query requests anyway.