Pin Postgres version in BackendRuntimeParams passed to compiler
#5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
force-pushed
the
compiler-pool-backend-version
branch
from
b8d6914
to
f3d9c98
Compare
nsidnev
reviewed
Jun 26, 2023
Force Postgres version in `BackendRuntimeParams` to be the minimal supported, because the compiler does not rely on the version, and not pinning it would make the remote compiler pool refuse connections from clients that have differing versions of Postgres backing them.
elprans
force-pushed
the
compiler-pool-backend-version
branch
from
f3d9c98
to
9023247
Compare
fantix
approved these changes
Jun 27, 2023
nsidnev
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force Postgres version in
BackendRuntimeParamsto be theminimal supported, because the compiler does not rely on
the version, and not pinning it would make the remote compiler
pool refuse connections from clients that have differing versions
of Postgres backing them.