Do not lose constraint errmessage when a constraint is ALTERed #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worst part here was that this could occur when the constraint was altered *implicitly* by _propagate_if_expr_refs because a pointer that it used was modified.
elprans
reviewed
Jun 27, 2023
| inherited['errmessage'] = True | ||
|
|
||
| attrs['errmessage'] = errmessage | ||
|
|
There was a problem hiding this comment.
I'm a bit puzzled how errmessage gets inherited from abstract constraints now
There was a problem hiding this comment.
Through the normal generic inheritance mechanisms, right?
As far as I could tell, errmessage doesn't need any special handling
elprans
approved these changes
Jun 27, 2023
msullivan
added a commit
that referenced
this pull request
Jul 6, 2023
The worst part here was that this could occur when the constraint was altered *implicitly* by _propagate_if_expr_refs because a pointer that it used was modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worst part here was that this could occur when the constraint
was altered implicitly by _propagate_if_expr_refs because a
pointer that it used was modified.