Properly track implicit dependance on __type__ in function calls
#5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing objects to functions, there is an implicit dependence on the `__type__` field (which may be used for function overloading). This dependence isn't tracked, so in inheritance cases a computed that depends on it may be processed before `__type__` is inherited. Fix this by making sure to get `__type__` through proper channels. Fixes #5661. In addition to actually fixing it, I added a hack that will make `__type__` always be processed first, to work around not easily being able to repair the expr refs in existing databases. We can drop the hack on our dev branch immediately, though. (I tested this flow manually.)
elprans
approved these changes
Jun 28, 2023
msullivan
added a commit
that referenced
this pull request
Jun 29, 2023
Remove a hack from #5715 that made the fix work on databases created prior to the fix.
msullivan
added a commit
that referenced
this pull request
Jul 6, 2023
…5715) When passing objects to functions, there is an implicit dependence on the `__type__` field (which may be used for function overloading). This dependence isn't tracked, so in inheritance cases a computed that depends on it may be processed before `__type__` is inherited. Fix this by making sure to get `__type__` through proper channels. Fixes #5661. In addition to actually fixing it, I added a hack that will make `__type__` always be processed first, to work around not easily being able to repair the expr refs in existing databases. We can drop the hack on our dev branch immediately, though. (I tested this flow manually.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing objects to functions, there is an implicit dependence on
the
__type__field (which may be used for function overloading).This dependence isn't tracked, so in inheritance cases a computed
that depends on it may be processed before
__type__is inherited.Fix this by making sure to get
__type__through proper channels.Fixes #5661.
In addition to actually fixing it, I added a hack that will make
__type__always be processed first, to work around not easily beingable to repair the expr refs in existing databases. We can drop the hack
on our dev branch immediately, though.
(I tested this flow manually.)