Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A result of tedious pg_dump debugging.
Tests on Postgres 15 were failing becuase they are using pg_dump 15,
which was producing the following statements that were
not produced by pg_dump 14:
Applying these dumps failed because type
edgedb."_SchemaAccessPolicy" did not exist.
After digging in pg_dump source code a bunch, trying to figure out
why these statements were showing up, I found a query similar to this:
After inspecting the results, I found that our resolver does not match
pg_type.typelem
to the outerpg_type
(as it should), but to the innerpg_type
, even though the innerpg_type
has an alias which should makethe orignal name inaccessible.
So that's the bug. With an easy fix.
Turns out that when I implemented the resolver I did not know this detail,
becuase we even had a test for it.