Fix healthchecks on single-database instances #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instances running on backends without `CREATE_DATABASE` capability will only have the `edgedb` database in them, while the healthcheck endpoints attempt to connect to the system database which is only present in multi-database mode. Fixes: #5895
elprans
force-pushed
the
single-db-healthcheck
branch
from
45f898e
to
73691b9
Compare
Comment on lines
+93
to
+95
| dbname = edbdef.EDGEDB_SYSTEM_DB | ||
| else: | ||
| dbname = edbdef.EDGEDB_SUPERUSER_DB |
There was a problem hiding this comment.
Will it be adjusted to the database name provided in BACKEND_DSN? i.e. if the (one and only) available database is named differently (not edgedb), will it still work?
In single db mode EdgeDB uses the database provided in --backend-dsn (EDGEDB_SERVER_BACKEND_DSN), e.g. if you give it postgres://host:port/mydb it'll use mydb.
There was a problem hiding this comment.
Yes. In single-database mode edgedb gets translated to whatever was specified in the backend DSN.
fantix
approved these changes
Aug 6, 2023
elprans
added a commit
that referenced
this pull request
Aug 22, 2023
Instances running on backends without `CREATE_DATABASE` capability will only have the `edgedb` database in them, while the healthcheck endpoints attempt to connect to the system database which is only present in multi-database mode. Fixes: #5895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instances running on backends without
CREATE_DATABASEcapability willonly have the
edgedbdatabase in them, while the healthcheck endpointsattempt to connect to the system database which is only present in
multi-database mode.
Fixes: #5895