Fix collisions between function parameters named id and the property #6000
+35
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We name function params their actual names, which can collide with the `id` column in tables and produce bad results. It could maybe collide with source and target in link tables too. It doesn't collide with everything, because most columns get uuid names. Qualify references to params with the function name. Fixes #5935.
elprans
reviewed
Aug 31, 2023
edb/pgsql/compiler/__init__.py
Outdated
| @@ -57,7 +57,7 @@ def compile_ir_to_sql_tree( | |||
| ignore_shapes: bool = False, | |||
| explicit_top_cast: Optional[irast.TypeRef] = None, | |||
| singleton_mode: bool = False, | |||
| use_named_params: bool = False, | |||
| use_named_params: Optional[tuple[str, ...]] = None, | |||
There was a problem hiding this comment.
Should we rename the arg to "named_arg_prefix" or something?
elprans
approved these changes
Aug 31, 2023
msullivan
added a commit
that referenced
this pull request
Sep 2, 2023
…6000) We name function params their actual names, which can collide with the `id` column in tables and produce bad results. It could maybe collide with source and target in link tables too. It doesn't collide with everything, because most columns get uuid names. Qualify references to params with the function name. Fixes #5935.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We name function params their actual names, which can collide with the
idcolumn in tables and produce bad results. It could maybe collidewith source and target in link tables too. It doesn't collide with
everything, because most columns get uuid names.
Qualify references to params with the function name.
Fixes #5935.