Fix function params whose name collide with SQL type names #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
approved these changes
Sep 22, 2023
We need to make sure to quote them. Unfortunately we can't *unconditionally* quote them in quote_ident, because when referring to them as types or builtin functions they need to not be quoted. Fixes #6062.
msullivan
force-pushed
the
invalid-syntax-name
branch
from
7cfe6d1
to
419a05f
Compare
msullivan
added a commit
that referenced
this pull request
Sep 26, 2023
We need to make sure to quote them. Unfortunately we can't *unconditionally* quote them in quote_ident, because when referring to them as types or builtin functions they need to not be quoted. Fixes #6062.
msullivan
added a commit
that referenced
this pull request
Sep 27, 2023
We need to make sure to quote them. Unfortunately we can't *unconditionally* quote them in quote_ident, because when referring to them as types or builtin functions they need to not be quoted. Fixes #6062.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure to quote them. Unfortunately we can't
unconditionally quote them in quote_ident, because when referring to
them as types or builtin functions they need to not be quoted.
Fixes #6062.