Fix cast of empty set to type with access policy #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug here was that the _inline_type_computable passed the wrong context, which could blow up, but only if the type had an access policy that hadn't been compiled yet (since we would then try to compile it), which is why it triggered in this case. Fixes #6070.
elprans
approved these changes
Sep 22, 2023
msullivan
added a commit
that referenced
this pull request
Sep 23, 2023
The bug here was that the _inline_type_computable passed the wrong context, which could blow up, but only if the type had an access policy that hadn't been compiled yet (since we would then try to compile it), which is why it triggered in this case. Fixes #6070.
msullivan
added a commit
that referenced
this pull request
Sep 27, 2023
The bug here was that the _inline_type_computable passed the wrong context, which could blow up, but only if the type had an access policy that hadn't been compiled yet (since we would then try to compile it), which is why it triggered in this case. Fixes #6070.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug here was that the _inline_type_computable passed the wrong
context, which could blow up, but only if the type had an access
policy that hadn't been compiled yet (since we would then try to
compile it), which is why it triggered in this case.
Fixes #6070.