Fix a protocol bug involving CONFIGURE INSTANCE #6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFIGURE INSTANCE didn't sync the state to a connection but we still indicated that it did on the pgcon. This could lead to state mismatch issues. Also fix another potential vector for such things that I don't think is actually currently possible (op that changes state but runs no sql).
msullivan
added a commit
that referenced
this pull request
Oct 12, 2023
CONFIGURE INSTANCE didn't sync the state to a connection but we still indicated that it did on the pgcon. This could lead to state mismatch issues. Also fix another potential vector for such things that I don't think is actually currently possible (op that changes state but runs no sql).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONFIGURE INSTANCE didn't sync the state to a connection but we still
indicated that it did on the pgcon. This could lead to state mismatch
issues.
Also fix another potential vector for such things that I don't think
is actually currently possible (op that changes state but runs no
sql).