Avoid pickling schemas on _every_ DDL statement when restoring a dump #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`restore()` doesn't care about anything other than compiled SQL or config ops, so pickling and returning the schema with every DDL query unit is wasteful, and, if the schema is large, quite slow.
msullivan
approved these changes
Oct 26, 2023
aljazerzen
pushed a commit
that referenced
this pull request
Oct 26, 2023
…#6362) `restore()` doesn't care about anything other than compiled SQL or config ops, so pickling and returning the schema with every DDL query unit is wasteful, and, if the schema is large, quite slow.
msullivan
pushed a commit
that referenced
this pull request
Oct 27, 2023
…#6362) `restore()` doesn't care about anything other than compiled SQL or config ops, so pickling and returning the schema with every DDL query unit is wasteful, and, if the schema is large, quite slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore()doesn't care about anything other than compiled SQL orconfig ops, so pickling and returning the schema with every DDL query
unit is wasteful, and, if the schema is large, quite slow.