Fix migrating between aliased and non-aliased computeds #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version is designed to be cherry-pickable to 4.x, so it doesn't change how any of our schemas are represented, it just tries to actually fully make the transition when we switch. I'm going to do a follow-up where I rip all of this out and the cost of schema changes.
aljazerzen
reviewed
Dec 8, 2023
Comment on lines
+1208
to
+1210
| (cur_base := self.scls.get_bases(schema).objects(schema)[0]) | ||
| and (subj := cur_base.get_subject(schema)) | ||
| and subj == self.scls.get_subject(schema) |
There was a problem hiding this comment.
This checks if my subject is also the subject of my first base.
So it checks that I'm haven't been rebased to a different subject?
Why is this here?
There was a problem hiding this comment.
This is detecting the case discussed in #6568, where an aliased computed is actually the subtype of the other pointer that it is aliasing
|
@elprans Could you take a look at this? |
elprans
approved these changes
Dec 11, 2023
aljazerzen
pushed a commit
that referenced
this pull request
Dec 15, 2023
This version is designed to be cherry-pickable to 4.x, so it doesn't change how any of our schemas are represented, it just tries to actually fully make the transition when we switch. I'm going to do a follow-up where I rip all of this out and the cost of schema changes.
msullivan
added a commit
that referenced
this pull request
Dec 19, 2023
This version is designed to be cherry-pickable to 4.x, so it doesn't change how any of our schemas are represented, it just tries to actually fully make the transition when we switch. I'm going to do a follow-up where I rip all of this out and the cost of schema changes.
msullivan
added a commit
that referenced
this pull request
Dec 20, 2023
This version is designed to be cherry-pickable to 4.x, so it doesn't change how any of our schemas are represented, it just tries to actually fully make the transition when we switch. I'm going to do a follow-up where I rip all of this out and the cost of schema changes.
aljazerzen
pushed a commit
that referenced
this pull request
Dec 21, 2023
This version is designed to be cherry-pickable to 4.x, so it doesn't change how any of our schemas are represented, it just tries to actually fully make the transition when we switch. I'm going to do a follow-up where I rip all of this out and the cost of schema changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is designed to be cherry-pickable to 4.x, so it doesn't
change how any of our schemas are represented, it just tries to
actually fully make the transition when we switch.
I'm going to do a follow-up where I rip all of this out and the cost
of schema changes.