Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error tolerance parameter to benchmarks #41

Open
vpetrovykh opened this issue Mar 23, 2022 · 0 comments
Open

Add an error tolerance parameter to benchmarks #41

vpetrovykh opened this issue Mar 23, 2022 · 0 comments

Comments

@vpetrovykh
Copy link
Member

Ideally we want 100% of queries to run without error. Realistically, we can probably allow a small percentage of them to fail without invalidating the benchmarks.

We need to report the error % in the results.
We should have a way to specify the allowed threshold beyond which the benchmarks are considered invalid and are aborted. Ideally, we should be able to show at least the last error in more details (noticing and debugging intermittent errors on benchmarks can be a pain right now).

The default should still be tuned to be high, like 99% must be successful. Not so high as to be indistinguishable from "not even a single error is allowed" especially for slower benchmarks, but high enough so that systemic intermittent errors are likely to trigger it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant