Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: grant Azure user-assigned managed identities all permissions previously granted to app registration #1334

Merged
merged 2 commits into from
Mar 21, 2023
Merged

cli: grant Azure user-assigned managed identities all permissions previously granted to app registration #1334

merged 2 commits into from
Mar 21, 2023

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Mar 3, 2023 •
edited

AB#2962. This is the first step of AB#2961

This is the first step for deprecating app registrations on Azure. The user-assigned managed identity (uami) should first gain all permissions that are currently held by the app registration.

Proposed change(s)

  • cli: give Azure uami all perms previously given to app registration

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@malt3 malt3 marked this pull request as ready for review March 6, 2023 14:43
@malt3 malt3 requested a review from katexochen as a code owner March 6, 2023 14:43
@malt3 malt3 added the no changelog Change won't be listed in release changelog label Mar 6, 2023
@malt3 malt3 added this to the v2.7.0 milestone Mar 6, 2023
@edgelesssys edgelesssys deleted a comment from netlify bot Mar 7, 2023
@katexochen katexochen removed the no changelog Change won't be listed in release changelog label Mar 7, 2023
katexochen
katexochen requested changes Mar 7, 2023
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the docs for manual IAM creation accordingly.

katexochen
katexochen reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm.

@katexochen katexochen self-assigned this Mar 7, 2023
@malt3 malt3 force-pushed the feat/azure/iam/uami-add-owner branch from 392d2a2 to c492f4e Compare March 9, 2023 15:34
@malt3
cli: give Azure uami all permissions previously given to app registra…
ee22b30 
…tion

This is the first step for deprecating app registrations on Azure.
The user-assigned managed identity (uami) should first gain all permissions that are currently held by the app registration.
@malt3
docs: document required owner role for user-assigned managed identity…
769cfd0 
… on Azure
@malt3 malt3 requested a review from katexochen March 20, 2023 14:19
@malt3 malt3 force-pushed the feat/azure/iam/uami-add-owner branch from c492f4e to 769cfd0 Compare March 20, 2023 14:20
@malt3 malt3 requested a review from thomasten as a code owner March 20, 2023 14:20
@malt3 malt3 merged commit 44db16b into main Mar 21, 2023
@malt3 malt3 deleted the feat/azure/iam/uami-add-owner branch March 21, 2023 09:00
@malt3 malt3 added the documentation Improvements or additions to documentation label Mar 21, 2023
@malt3 malt3 changed the title cli: give Azure uami all perms previously given to app registration cli: give Azure user-assigned managed identities all permissions previously given to app registration Mar 21, 2023
@malt3 malt3 changed the title cli: give Azure user-assigned managed identities all permissions previously given to app registration cli: grant Azure user-assigned managed identities all permissions previously granted to app registration Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

Assignees

@katexochen katexochen

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malt3 @katexochen