Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: list minimal permissions set required for Constellation setup #1442

Merged
merged 18 commits into from
Mar 30, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Mar 17, 2023

Proposed change(s)

  • List the minimal permissions to be able to execute the constellation iam commands (iam create & iam destroy) for each CSP.

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Link to Milestone

@msanft msanft added the feature This introduces new functionality label Mar 17, 2023
@msanft msanft added this to the v2.7.0 milestone Mar 17, 2023
@msanft msanft requested a review from katexochen March 17, 2023 09:37
@msanft msanft requested a review from thomasten as a code owner March 17, 2023 09:37
@msanft msanft changed the title Feat/iam permission list docs: list minimal permissions for iam commands Mar 17, 2023
@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit b7a5260
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/642544d7dfd059000827bc32
😎 Deploy Preview https://deploy-preview-1442--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@katexochen
Copy link
Member

@msanft Nice, thanks for the work! Could you please validate that we use that exact permissions in the CI for our e2e testing? That way we'll quickly notice if anything changes (at least if we require more permissions).

@msanft
Copy link
Contributor Author

msanft commented Mar 22, 2023

We should probably merge this with https://docs.edgeless.systems/constellation/getting-started/install#set-up-cloud-credentials and also extend the docs on which permissions are needed for cluster creation there. (as its already done on AWS)

@msanft msanft changed the title docs: list minimal permissions for iam commands docs: list minimal permissions for Constellation setup Mar 22, 2023
@msanft msanft requested review from thomasten and Nirusu March 23, 2023 09:31
@msanft msanft removed the request for review from katexochen March 23, 2023 09:32
docs/docs/getting-started/install.md Outdated Show resolved Hide resolved
docs/docs/getting-started/install.md Outdated Show resolved Hide resolved
docs/docs/getting-started/install.md Outdated Show resolved Hide resolved
docs/docs/getting-started/install.md Outdated Show resolved Hide resolved
msanft and others added 5 commits March 26, 2023 12:25
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
@msanft
Copy link
Contributor Author

msanft commented Mar 26, 2023

{"message": "[Vale.Spelling] Did you really mean 'superset'?", "location": {"path": "docs/docs/getting-started/install.md", "range": {"start": {"line": 129, "column": 32}}}, "severity": "ERROR"}

Any way to silence the review-🐶 here?

@msanft msanft requested a review from thomasten March 26, 2023 17:08
docs/docs/getting-started/install.md Outdated Show resolved Hide resolved
docs/docs/getting-started/install.md Show resolved Hide resolved
Copy link
Contributor

@Nirusu Nirusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to set Microsoft.Attestation above for the required registered providers, too. You maybe can merge the footnotes for this, but not sure how it would look good given that they are in separate paragraphs.

@msanft
Copy link
Contributor Author

msanft commented Mar 28, 2023

Don't forget to set Microsoft.Attestation above for the required registered providers, too. You maybe can merge the footnotes for this, but not sure how it would look good given that they are in separate paragraphs.

Yeah I will need to look at this in the version built by Docusaurus. Just saved it so that I don't forget about it the next time I come back to this

@msanft msanft mentioned this pull request Mar 30, 2023
2 tasks
msanft and others added 4 commits March 30, 2023 10:10
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
Co-authored-by: Nils Hanke <Nirusu@users.noreply.github.com>
@msanft msanft merged commit 1f7acf8 into main Mar 30, 2023
@msanft msanft deleted the feat/iam-permission-list branch March 30, 2023 08:16
@katexochen katexochen changed the title docs: list minimal permissions for Constellation setup docs: list minimal permissions set required for Constellation setup Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This introduces new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants