-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental support for OpenStack #1443
Conversation
ae4abfe
to
8cd50b1
Compare
I'm seeing two issues when trying
You can use this patch for testing (it is valid for OpenStack tests but cannot go into main): diff --git a/bootstrapper/cmd/bootstrapper/run.go b/bootstrapper/cmd/bootstrapper/run.go
index 0a6639b2..b74b91a8 100644
--- a/bootstrapper/cmd/bootstrapper/run.go
+++ b/bootstrapper/cmd/bootstrapper/run.go
@@ -46,7 +46,8 @@ func run(issuer atls.Issuer, tpm vtpm.TPMOpenFunc, fileHandler file.Handler,
nodeBootstrapped, err := vtpm.IsNodeBootstrapped(tpm)
if err != nil {
- log.With(zap.Error(err)).Fatalf("Failed to check if node was previously bootstrapped")
+ // TODO(malt3): convert back to error
+ log.With(zap.Error(err)).Warnf("Failed to check if node was previously bootstrapped")
}
if nodeBootstrapped {
diff --git a/bootstrapper/internal/helm/helm.go b/bootstrapper/internal/helm/helm.go
index a1491c2e..3abd5039 100644
--- a/bootstrapper/internal/helm/helm.go
+++ b/bootstrapper/internal/helm/helm.go
@@ -85,7 +85,8 @@ func (h *Client) InstallCertManager(ctx context.Context, release helm.Release) e
h.Timeout = 10 * time.Minute
if err := h.install(ctx, release.Chart, release.Values); err != nil {
- return err
+ // TODO(malt3): Remove this once cert-manager is stable.
+ h.log.With(zap.Error(err)).Warnf("failed to install cert-manager")
}
return nil |
8cd50b1
to
9d67708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed up to and including d6fdd29
Tested with the additional patch from the comment ✔️. Code LGTM after Paul's changes. |
31371c6
to
5050188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. We should work on adding openstack e2e tests next.
5050188
to
f3556b1
Compare
Proposed change(s)
Additional info
Checklist