cli: do not recreate os disk during upgrade by keeping Azure ConfidentialVM setting during upgrade #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
added
bug fix
This comment was marked as off-topic.
This comment was marked as off-topic.
derpsteb
approved these changes
Jul 18, 2023
|
For visibility: there will be another PR to handle Terraform variables similarly in create and upgrade. |
malt3
changed the title
derpsteb
pushed a commit
that referenced
this pull request
Jul 19, 2023
derpsteb
changed the title
derpsteb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
ConfidentialVMoption was never set when applying terraform migrations, leading to it being default initialized asfalse.This in turn leads to the upgrade trying to change the settings for node groups on Azure from confidential VMs to non-confidential VMs.
Proposed change(s)
Checklist