Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: limit Terraform version to FOSS releases #2241

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

thomasten
Copy link
Member

Context

Starting with v1.6, Terraform will be licensed under BUSL. v1.5 will get critical security updates until end of 2023.

Proposed change(s)

  • Limit Terraform version to open-source releases until it's clear how we proceed.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@thomasten thomasten added this to the v2.11.0 milestone Aug 16, 2023
@thomasten thomasten requested a review from 3u13r August 16, 2023 08:40
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 1cf1062
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64dcbfae067c8a00089636c4
😎 Deploy Preview https://deploy-preview-2241--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elchead
Copy link
Contributor

elchead commented Aug 16, 2023

have you tested that it works with the space? I only read "comma separated list"

@thomasten
Copy link
Member Author

have you tested that it works with the space? I only read "comma separated list"

Yes, I have. Works.

@3u13r
Copy link
Member

3u13r commented Aug 16, 2023

I pushed a fix which enforces enforces the upper version constraint for the downloaded version. The constraints in "LatestRelease" are never used and the truly latest version is downloaded.
One can manually check this by uninstalling all local terraform versions and changing the upper bound to e.g. <1.5.0.

@3u13r 3u13r removed their request for review August 16, 2023 12:27
Copy link
Member Author

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasten thomasten merged commit 587ae6a into main Aug 16, 2023
11 of 12 checks passed
@thomasten thomasten deleted the feat/cli/tfver branch August 16, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants