Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix incorrect actual values for constellation verify on AWS #2265

Merged
merged 2 commits into from
Aug 21, 2023
Merged

cli: fix incorrect actual values for constellation verify on AWS #2265

merged 2 commits into from
Aug 21, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Aug 21, 2023 •
edited

Context

Proposed change(s)

  • Use the same struct and PCR extraction as in the aTLS verifier

verify, aws: https://github.com/edgelesssys/constellation/actions/runs/5925328580

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit acf6e53
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64e3434129b1a70008bc41d9

@3u13r 3u13r added the bug fix Fixing a bug label Aug 21, 2023
@3u13r 3u13r added this to the v2.11.0 milestone Aug 21, 2023
@3u13r 3u13r changed the title cli: fix aws pcr index cli: fix incorrect actual values for constellation verify on AWS Aug 21, 2023
@3u13r 3u13r marked this pull request as ready for review August 21, 2023 09:39
@3u13r
Copy link
Member Author

3u13r commented Aug 21, 2023

I'm not sure about the additional dependency, Feel free to make suggestions.

katexochen
katexochen approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

cli/internal/cmd/verify.go Outdated Show resolved Hide resolved
cli/internal/cmd/verify.go Outdated Show resolved Hide resolved
@3u13r 3u13r force-pushed the fix/cli/verify-aws-sha-idx branch from 5feda16 to 074684a Compare August 21, 2023 10:56
@3u13r 3u13r merged commit bb654ba into main Aug 21, 2023
9 checks passed
@3u13r 3u13r deleted the fix/cli/verify-aws-sha-idx branch August 21, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@daniel-weisse daniel-weisse daniel-weisse approved these changes

Assignees
No one assigned
Labels
bug fix Fixing a bug
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@3u13r @katexochen @daniel-weisse