cli: add spinner to helm chart installation #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
✅ Deploy Preview for constellation-docs canceled.
|
msanft
reviewed
Aug 21, 2023
msanft
reviewed
Aug 21, 2023
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
feat/cli/helm-spinner
branch
from
e2892ae
to
5e566b5
Compare
msanft
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our CLI currently runs through 3 phases during
constellation init:Only the first two phases have a spinner dedicated to them.
During the helm chart installation no spinner is shown.
Additionally, the spinner for the init RPC is stopped, so the user is left with a unresponsive looking CLI.
Proposed change(s)
Additional info
Installing Kubernetes components, feel free to suggest another status message if you feel this is not optimal.