cli: generate state file during constellation config generate
#2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
daniel-weisse
approved these changes
Oct 16, 2023
elchead
approved these changes
Oct 16, 2023
msanft
force-pushed
the
feat/cli/config-state-file-generation
branch
from
cd7b368
to
8291e26
Compare
msanft
force-pushed
the
feat/cli/config-state-file-generation
branch
from
8291e26
to
aba3d0e
Compare
Coverage report
|
elchead
pushed a commit
that referenced
this pull request
Oct 17, 2023
* create state file during config generate * use written file in `constellation create` * document creation of state file * remove accidentally added test * check error when writing state file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a first step towards self-managed infrastructure support, it is necessary to provide the user with a way to generate a state file before the normal cluster creation would happen (as that step is not performed in the self-managed infrastructure case).
Proposed change(s)
constellation config generate <CSP>constellation create, this is not necessary as the file would be overwritten, but creates a more coherent flow between Constellation-managed and self-managed infrastructure.Additional info
Checklist