operator: fix get-handling of Azure marketplace images #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
daniel-weisse
requested changes
Jan 23, 2024
operators/constellation-node-operator/internal/cloud/azure/client/nodeimage.go
Outdated
Show resolved
Hide resolved
operators/constellation-node-operator/internal/cloud/azure/client/nodeimage.go
Outdated
Show resolved
Hide resolved
operators/constellation-node-operator/internal/cloud/azure/client/scalinggroup.go
Outdated
Show resolved
Hide resolved
daniel-weisse
approved these changes
Jan 24, 2024
malt3
approved these changes
Jan 24, 2024
msanft
force-pushed
the
fix/operator/mp-image-getter
branch
from
c62cdd3
to
37aaaab
Compare
msanft
force-pushed
the
fix/operator/mp-image-getter
branch
from
37aaaab
to
a8e5453
Compare
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Cluster creation and upgrades with Azure marketplace images were broken due to an unimplemented operation in the operator (i.e. getting VMSS state and Node state), that caused the reconcile loop to fail, resulting in indefinitely hanging upgrades and cluster creation.
Proposed change(s)
Additional Information
Checklist