Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: performance fixes and reproducible images #2855

Merged
merged 4 commits into from
Jan 26, 2024
Merged

cilium: performance fixes and reproducible images #2855

merged 4 commits into from
Jan 26, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jan 25, 2024 •
edited
Loading

Context

The next release of our Cilium fork has three significant changes:

  • A fix for a pod-to-pod performance regression in the upstream 1.15 pre-release is mitigated (wrong MTU settings, the fix is not yet accepted upstream).
  • Node-to-node performance is significantly improved by advertising a low-enough MSS to avoid fragmentation.
  • The Edgeless Cilium images are now reproducibly built starting from their upstream bases.

Proposed change(s)

  • Upgrade Cilium fork version.
  • Adjust the Chart version to our forked tag, so that it is considered an update.

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone
  • Test runs
  • Use "real" release tag

@burgerdev burgerdev added the bug fix Fixing a bug label Jan 25, 2024
@burgerdev burgerdev added this to the v2.15.0 milestone Jan 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 25, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 9dad071
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65b28207c313430008a29aac

@burgerdev burgerdev marked this pull request as ready for review January 25, 2024 15:33
@burgerdev burgerdev requested review from malt3 and removed request for derpsteb January 25, 2024 15:33
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
internal/constellation/helm 53.20% 53.20% ↔️

@burgerdev burgerdev requested a review from 3u13r January 25, 2024 21:28
malt3
malt3 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @3u13r is the right person to review the version change regarding performance fixes. Looks fine from my somewhat limited experience.

3u13r
3u13r approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev merged commit 597a923 into main Jan 26, 2024
8 checks passed
@burgerdev burgerdev deleted the burgerdev/bump-cilium branch January 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@3u13r 3u13r 3u13r approved these changes

Assignees
No one assigned
Labels
bug fix Fixing a bug
Projects
None yet
Milestone
v2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@burgerdev @malt3 @3u13r