Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: patch Go SDK to increase TLS maxHandshake size #3009

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Apr 3, 2024

Context

Go has a very small default for the maximum handshake size in TLS (65536 bytes), while the protocol specifies a maximum of 16 MB.
Since aTLS adds a lot of additional data to TLS certificates, an increase of this handshake size is needed.
Currently, this requires a patch of the Go SDK.

Proposed change(s)

  • bazel: patch Go SDK to increase tls maxHandshake size

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@malt3 malt3 added the bug fix Fixing a bug label Apr 3, 2024
@malt3 malt3 added this to the v2.17.0 milestone Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit c707458
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/660d3c1921bb390008038a5b

@malt3 malt3 requested a review from daniel-weisse April 3, 2024 11:31
@daniel-weisse
Copy link
Member

@malt3 malt3 marked this pull request as ready for review April 3, 2024 12:08
@malt3 malt3 merged commit 24c346c into main Apr 3, 2024
5 checks passed
@malt3 malt3 deleted the fix/bazel/go-sdk-max-handshake-size branch April 3, 2024 12:08
@msanft msanft changed the title bazel: patch Go SDK to increase tls maxHandshake size bazel: patch Go SDK to increase TLS maxHandshake size Apr 4, 2024
@daniel-weisse daniel-weisse added the needs backport This PR needs to be backported to a previous release label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug needs backport This PR needs to be backported to a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants