Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: enable JSON output for constellation verify on Azure TDX #3164

Merged
merged 3 commits into from
Jun 12, 2024
Merged

cli: enable JSON output for constellation verify on Azure TDX #3164

merged 3 commits into from
Jun 12, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Jun 12, 2024 •
edited
Loading

Context

Our CI parses the JSON output of constellation verify in order to upload the latest CC claims to Constellation's CDN.
For now, this was only enabled for SEV-SNP attestation variants.

Proposed change(s)

  • Enabled JSON output for Azure TDX
    • The TDX library we use also handles JSON marshalling of the quote, so I didn't implement any extra methods, unlike we did for SNP. This means we won't have pretty formatted text output for TDX variants, but this can always be added at a later date since it doesn't have high priority: AB#4266
  • Simplify the constellation verify code a bit by removing the formatter factory

Additional info

@daniel-weisse
Remove formater factory
574a081 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse
Enable CLI verify with JSON output for Azure TDX
3e91f1a 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse added the feature This introduces new functionality label Jun 12, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit b3fbd44
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/66697f51a8a5030008874818

msanft
msanft approved these changes Jun 12, 2024
View reviewed changes
cli/internal/cmd/verify.go Outdated Show resolved Hide resolved
@daniel-weisse
Move type switch for better error reporting
b3fbd44 
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 41.00% 40.90% ↘️
internal/attestation/azure/tdx 8.80% 8.80% 🚧
internal/verify 8.00% 8.00% 🚧

@daniel-weisse daniel-weisse merged commit daaa775 into main Jun 12, 2024
9 checks passed
@daniel-weisse daniel-weisse deleted the feat/cli/tdx-json-output branch June 12, 2024 11:18
@daniel-weisse daniel-weisse mentioned this pull request Jun 17, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-weisse @msanft