Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix constellation verify depending on an initialized constellation-state.yaml file #3184

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

daniel-weisse
Copy link
Member

Context

constellation verify should be usable with only a config file, the IP of the service, and the cluster ID of a Constellation cluster

Proposed change(s)

  • Remove dependency on an initialized constellation-state.yaml when executing constellation verify with --endpoint and --cluster-id flags set
  • More prominently mention requirement for constellation-conf.yaml for constellation verify in our docs

Related issue

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse added the bug fix Fixing a bug label Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit e90cc10
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/667528962952aa0008a3dd8c
😎 Deploy Preview https://deploy-preview-3184--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/docs/workflows/verify-cluster.md Outdated Show resolved Hide resolved
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 41.00% 41.00% 🚧

@daniel-weisse daniel-weisse merged commit 09d19fe into main Jun 21, 2024
11 checks passed
@daniel-weisse daniel-weisse deleted the fix/cli/verify-flags branch June 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect docs: verifying third-party clusters with CLI
2 participants