Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential data race when accessing a validators OID #640

Merged
merged 1 commit into from Nov 24, 2022

Conversation

daniel-weisse
Copy link
Member

Proposed change(s)

  • Add a lock to *Updatable.OID() to prevent data race when calling the function in parallel to *Updatable.Update(), which can happen if a client connects to the server at the same time the sever is updating its validator

Checklist

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit b05adeb
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/637f6aaccd047400080e52c2

Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-weisse daniel-weisse merged commit c2ea937 into main Nov 24, 2022
@daniel-weisse daniel-weisse deleted the fix/internal/watcher/data-race branch November 24, 2022 14:51
msanft pushed a commit that referenced this pull request Nov 30, 2022
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants