Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the detection of Dynalist tags #42

Closed
tanius opened this issue Sep 5, 2018 · 0 comments
Closed

Fix the detection of Dynalist tags #42

tanius opened this issue Sep 5, 2018 · 0 comments

Comments

@tanius
Copy link
Member

tanius commented Sep 5, 2018

Currently, @mentions and #name tags for task assignment are detected here with a regex \s@([a-z]{3,15}) and \s#([a-z]{3,15}), respectively.

However, some usernames on edgeryders.eu and thus tag names in our Dynalist documents contains special characters, for example: #anique.yael. It's a valid tag in Dynalist, as can be seen from the gray background formatting for the whole thing (not stopping before the dot) when entering it in Dynalist. Likewise, the restriction to 3-15 characters in length is arbitrary.

The clean solution here will be to detect all tags that are valid in Dynalist. For that, find out first what special characters can be contained in Dynalist tags, and adapt the regex accordingly. We should not try to apply any stricter rules on "what is a tag" than Dynalist, as others will use our software without these same conventions (that might come from Discourse usernames in our case, but others won't have Discourse).

(Then, as it is already happening, the application will try to look up an associated e-mail for each tag appearance, and send an e-mail for those where it succeeds. No changes needed in that part.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant